Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add createSchema and getSchema util methods #60

Merged
merged 21 commits into from
Jul 18, 2024
Merged

add createSchema and getSchema util methods #60

merged 21 commits into from
Jul 18, 2024

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Jun 28, 2024 •
edited
Loading

Description

Add util functions to create and get schema.

PR for the exported function used from conduit: # ConduitIO/conduit#1683

todos:

  • use the proto messages and the proto convert functions from commons (not there yet)
  • use the schema service from conduit to get and create the schema for builtin connector. (when schema service is implemented in conduit)

Related to #45

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner June 28, 2024 23:19
@maha-hajja maha-hajja mentioned this pull request Jun 29, 2024
Merged
4 tasks
lovromazgon
lovromazgon reviewed Jul 3, 2024
View reviewed changes
schema/schema_wasm.go Outdated Show resolved Hide resolved
proto/processor/v1/processor.proto Outdated Show resolved Hide resolved
schema/schema_wasm.go Outdated Show resolved Hide resolved
wasm/util.go Outdated Show resolved Hide resolved
wasm/errors.go Outdated Show resolved Hide resolved
wasm/util.go Outdated Show resolved Hide resolved
hariso
hariso reviewed Jul 8, 2024
View reviewed changes
wasm/imports.go Outdated Show resolved Hide resolved
hariso
hariso reviewed Jul 8, 2024
View reviewed changes
wasm/imports.go Outdated Show resolved Hide resolved
@maha-hajja maha-hajja requested review from hariso and lovromazgon July 11, 2024 00:22
lovromazgon
lovromazgon reviewed Jul 12, 2024
View reviewed changes
proto/conduit/v1/schema.proto Show resolved Hide resolved
schema/fromproto.go Outdated Show resolved Hide resolved
schema/schema.go Outdated Show resolved Hide resolved
wasm/caller.go Outdated Show resolved Hide resolved
wasm/command.go Outdated Show resolved Hide resolved
wasm/schema.go Outdated Show resolved Hide resolved
@maha-hajja maha-hajja requested a review from lovromazgon July 17, 2024 02:38
lovromazgon
lovromazgon approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, let's add the in-memory service in the next PR 👍

@maha-hajja maha-hajja merged commit a0c11f3 into main Jul 18, 2024
5 checks passed
@maha-hajja maha-hajja deleted the maha/create-get-schema branch July 18, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

@hariso hariso Awaiting requested review from hariso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maha-hajja @hariso @lovromazgon